Skip to content

design-tokens : allow unit assignments #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Aug 27, 2022

see #588

@@ -45,7 +45,7 @@
},
"devDependencies": {
"postcss-import": "^14.1.0",
"style-dictionary-design-tokens-example": "^1.0.0"
"style-dictionary-design-tokens-example": "^1.1.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "exports" field was incorrect there.
Noticed it while trying to node module resolutions.

No work was done to resolve modules in this PR, but updating the package anyway.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This looks great!

@romainmenke romainmenke merged commit c3611f4 into main Aug 30, 2022
@romainmenke romainmenke deleted the design-tokens-allow-unit-assignments--philosophical-bullfrog-9856c8cd21 branch August 30, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants