Skip to content

cascade-layers : add support for scope and container at rules #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Sep 7, 2022

I think this is the right way to add support for @scope and @container.
I initially thought it would be complicated to resolve the issue and didn't immediately attempt a fix. But it seems that just adding it them the list of allowedParentAtRules was enough.

See : #610

These two at rules no longer affect the layer order.

very low prio as very few people use @layer and even less will be using it with @container or @scope

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for adding this!

…ntainer--unassuming-old-english-sheepdog-d6805b4382
@romainmenke romainmenke merged commit 6ba4152 into main Sep 14, 2022
@romainmenke romainmenke deleted the cascade-layers--add-support-for-scope-and-container--unassuming-old-english-sheepdog-d6805b4382 branch September 14, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants