-
-
Notifications
You must be signed in to change notification settings - Fork 75
postcss-lab-function : gamut mapping and display-p3 #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postcss-lab-function : gamut mapping and display-p3 #70
Conversation
…nate-crab-6c5bb7cdbb
…nate-crab-6c5bb7cdbb
This comment has been minimized.
This comment has been minimized.
…nate-crab-6c5bb7cdbb
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…nate-crab-6c5bb7cdbb
…nate-crab-6c5bb7cdbb
@Antonio-Laguna Also includes a few small readme and test comment fixes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astounding! This looks great! Thanks a lot for doing all of this and being the Color expert! Love that we've lost the python scripts too :)
Left some minor nitpicky comments/suggestions mostly on wordings. Let me know if you want to discuss any of them.
Would it make sense to abstract those transformation functions into their own package? We're repeating all of these functions here and elsewhere and even though they shouldn't change, it would be better if they were centralized. Thoughts? Sharing code between plugins is always a recurring theme here 😂
Try color expert. Your work will affect of how people will work with colors in CSS. |
Co-authored-by: Antonio Laguna <sombragriselros@gmail.com>
…ithub.com/csstools/postcss-plugins into css-color-4--affectionate-crab-6c5bb7cdbb
In my head it looks something like this :
At this point I found that I did not need to change anything between My main concern is creating roadblocks for myself. Copy/paste is just the cheapest way to reuse code while writing.
Thank you for those!
hehe, just reading the specs and depending on the awesome work and examples by @svgeesus and @LeaVerou among others. My main contribution is time :) |
…nate-crab-6c5bb7cdbb
…nate-crab-6c5bb7cdbb
@Antonio-Laguna This contains unreleased changes for :
|
Sounds like a great plan to me!
Don't sell yourself short! This is huge ❤️ |
All done!
|
Hey @romainmenke, I noticed you're using the sample code for the specs. We (@svgeesus and I) have actually also authored a library to make conversions like this easier: https://colorjs.io/ |
@LeaVerou Using that library would be awesome going forward. We are also very cautious when adding new features and dependencies as For |
Bring
postcss-lab-function
up to speed withcss-color-4
Also tracked in this effort :
lab
,lch
,hwb
, ...)postcss-color-functional-notation
)notes :