postcss-is-pseudo-class : fix :not pseudo interaction
#828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:not pseudo interaction
Antonio-Laguna
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #827
:not(is(a, b, c))can not be rewritten as a forgiving selector.It is either the wrong selector (current behavior) or an unforgiving list (new behavior).
The only reason to split all these selectors so aggressively is to be a 100% sure that every rule will be valid or invalid individually.
But we actually know for a lot of these that they will always be valid.
Only new pseudo's, nesting or unknown combinators can trigger invalid selectors.
To be super cautious I also included case insensitive attribute matching.
We can tweak the logic as needed.