-
-
Notifications
You must be signed in to change notification settings - Fork 75
Reduce the amount of generated fallback css (batch 1) #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romainmenke
merged 16 commits into
main
from
reduce-the-amount-of-generated-fallback-css-passionate-fire-bellied-toad-66ff6b4b7d
Feb 5, 2023
Merged
Reduce the amount of generated fallback css (batch 1) #835
romainmenke
merged 16 commits into
main
from
reduce-the-amount-of-generated-fallback-css-passionate-fire-bellied-toad-66ff6b4b7d
Feb 5, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonio-Laguna
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so clever!
Love this a lot and I'm glad this improves the output!
…passionate-fire-bellied-toad-66ff6b4b7d
This was referenced Feb 7, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common-tools
plugins/css-blank-pseudo
plugins/css-has-pseudo
plugins/css-prefers-color-scheme
plugins/postcss-attribute-case-insensitive
plugins/postcss-color-function
plugins/postcss-color-functional-notation
plugins/postcss-color-hex-alpha
plugins/postcss-color-rebeccapurple
plugins/postcss-dir-pseudo-class
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple issues, we can't fix them all but we can do a little bit more here and there to improve things a lot overal.
1: We can keep track of which nodes we generated fallbacks for and skip them
2: We can look at the previous declaration
3: Same as 2
For users this change must be unnoticeable.
example issue :