fix exceptions from missing graph nodes #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60ba247 to
dd20150
Compare
Antonio-Laguna
approved these changes
Feb 8, 2023
…ssing-graph-nodes--gregarious-indian-star-tortoise-bc6945d6e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes :
Two things went wrong here :
1: I copy/pasted the logic to detect cyclic dependencies from design tokens to other parts.
I didn't cleanup some specific logic that was only intended for design tokens. If a token is missing we throw in that plugin, that is fine because it has different heuristics.
Not fine at all in polyfill/fallback plugins.
2: Strangely we didn't have any tests for dependencies between custom props or custom media were finally a value is missing.