postcss-tape : convert to workspace package #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Feb 27, 2023
packages/postcss-tape/README.md
Outdated
Comment on lines
31
to
36
| ## After node 20 is released do a find/replace to migrate fully to workspaces : | ||
|
|
||
| - `import { postcssTape } from '../../packages/postcss-tape/dist/index.mjs';` | ||
| - `import { postcssTape } from '@csstools/postcss-tape';` | ||
|
|
||
| Then add `@csstools/postcss-tape` the each `package.json` as a dev dependency. |
There was a problem hiding this comment.
We are now using a more recent npm version when testing node 14.
So we can do this migration sooner.
Comment on lines
+87
to
+93
| let packageName = packageInfo.name; | ||
| if (packageName.startsWith('@')) { | ||
| const parts = packageInfo.name.split('/'); | ||
| packageName = parts.slice(1).join('/'); | ||
| } | ||
|
|
||
| if (!packageName.startsWith('postcss-') && !isOlderPackageName) { |
There was a problem hiding this comment.
This should work well for 3rd party scoped packages. @foo/postcss-bar
| export type TestCaseOptions = { | ||
| // Debug message | ||
| /** Debug message */ |
There was a problem hiding this comment.
This format of comments is exported and published, the other is not.
| @@ -39,7 +39,6 @@ | |||
| "dist" | |||
| ], | |||
| "peerDependencies": { | |||
| "postcss": "^8.4", | |||
There was a problem hiding this comment.
Weird bug that I noticed when adding the dev dependency for @csstools/postcss-tape.
This package doesn't use postcss at all.
Antonio-Laguna
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor we planned to do anyway and a few minor tweaks to make the package suitable for 3rd parties.
It can be released so that others can also make use of it.
apparently the labeler also has a hard limit 😂