postcss-gradients-interpolation-method : leverage @csstools/css-color-parser
#901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Mar 24, 2023
|
@romainmenke this LGTM! I don't think anyone will be impacted by this being major to a worse experience but I trust your gut! |
Antonio-Laguna
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/csstools/postcss-plugins/blob/270ddd3f7826ba981272f3f91f47fb1e8dd27981/plugins/postcss-gradients-interpolation-method/README.md
I've made this a breaking change because it is a complete rewrite.
I wouldn't yet add it to
postcss-preset-env, but I think it is good to have some extra coverage forcolor-mixat this time.The parser algorithm is more complex/messy than I would like which is why I don't feel fully confident in this yet. But should be ready for release so that people can play with it.