is-pseudo : handle more complex selector patterns #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Apr 6, 2023
Comment on lines
1
to
+10
| // :-csstools-matches(.a > .b) + :-csstools-matches(.c > .d) | ||
| // equivalent to | ||
| // .a.c > .b + .d | ||
| // | ||
| // and | ||
| // | ||
| // :-csstools-matches(.a > .b) ~ :-csstools-matches(.c > .d) | ||
| // equivalent to | ||
| // .a.c ~ .b + .d | ||
| // |
There was a problem hiding this comment.
These are actually the same, trivial to support both.
Comment on lines
+64
to
+84
| const previous = sortedCompoundSelectors[i - 1]; | ||
|
|
||
| sortedCompoundSelectors[i].remove(); | ||
| node.prepend(sortedCompoundSelectors[i]); | ||
|
|
||
| if (previous && previous.type === 'tag' && sortedCompoundSelectors[i].type === 'tag') { | ||
| const wrapped = parser.pseudo({ | ||
| value: ':is', | ||
| nodes: [ | ||
| parser.selector({ | ||
| value: '', | ||
| nodes: [ | ||
| sortedCompoundSelectors[i], | ||
| ], | ||
| }), | ||
| ], | ||
| }); | ||
|
|
||
| node.prepend(wrapped); | ||
| } else { | ||
| node.prepend(sortedCompoundSelectors[i]); | ||
| } |
There was a problem hiding this comment.
Sorting will group tag selectors a and b into ab which serializes as a single tag ab.
This bit is a "post fix" to wrap it back with :is() into a:is(b)
| @@ -1,7 +1,7 @@ | |||
| import parser from 'postcss-selector-parser'; | |||
|
|
|||
| export function sortCompoundSelectorsInsideComplexSelector(node) { | |||
| if (!node || !node.nodes) { | |||
| if (!node || !node.nodes || node.nodes.length === 1) { | |||
There was a problem hiding this comment.
:is(a) cause issues and doesn't require sorting anyway.
Better to short circuit.
| background-color: #ffc; | ||
| } | ||
|
|
||
| :is(:-csstools-matches(.a, .b)) > .c { |
There was a problem hiding this comment.
I want to be sure that code looking for :-csstools-matches can also handle selector lists.
Internally we never produce :-csstools-matches with lists, but want to cover it anyway.
(We produce :-csstools-matches as an intermediate step with partially transpiled selectors to prevent infinite loops.)
3 tasks
Antonio-Laguna
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #922