-
-
Notifications
You must be signed in to change notification settings - Fork 75
nesting : latest specification #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nesting : latest specification #996
Conversation
@@ -1,5 +1,9 @@ | |||
# Changes to PostCSS Preset Env | |||
|
|||
### Unreleased (minor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this a minor so that people won't be surprised by the warning.
…trian-camel-a08693ad83
…trian-camel-a08693ad83
…trian-camel-a08693ad83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Thanks for making all of the changes and the amount of tests!!
@@ -6,13 +6,16 @@ import walk from './lib/walk.js'; | |||
export type pluginOptions = { | |||
/** Avoid the `:is()` pseudo class as much as possible. default: false */ | |||
noIsPseudoSelector?: boolean, | |||
/** Silence the `@nest` warning. */ | |||
silenceAtNestWarning?: boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also be worth to surface on the CHANGELOG? Users seem to look for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thank you 🙇
I've added it in the CHANGELOG and general README.
I also linked to the Stylelint plugin.
…ication--empathetic-bactrian-camel-a08693ad83
@nest
rule