Skip to content

nesting : latest specification #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Jun 4, 2023

  • Add warning when using the deprecated @nest rule
  • Add support for nested selectors that that begin with a letter

@@ -1,5 +1,9 @@
# Changes to PostCSS Preset Env

### Unreleased (minor)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this a minor so that people won't be surprised by the warning.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!

Thanks for making all of the changes and the amount of tests!!

@@ -6,13 +6,16 @@ import walk from './lib/walk.js';
export type pluginOptions = {
/** Avoid the `:is()` pseudo class as much as possible. default: false */
noIsPseudoSelector?: boolean,
/** Silence the `@nest` warning. */
silenceAtNestWarning?: boolean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be worth to surface on the CHANGELOG? Users seem to look for these

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you 🙇

I've added it in the CHANGELOG and general README.
I also linked to the Stylelint plugin.

@romainmenke romainmenke merged commit b4220ea into main Jun 13, 2023
@romainmenke romainmenke deleted the nesting-latest-specification--empathetic-bactrian-camel-a08693ad83 branch June 13, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants