-
Notifications
You must be signed in to change notification settings - Fork 31
update: add support for postcss 8 & update dependencies #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
support postcss 8; fix bugs in tests; upate deps; update build process postcss-import@latest doesn't seem to import without .scss
postcss 8 & rollup prefers node v12+
|
Any news on this PR? Latest version autoprefixer throws an error because of the postcss 7 dependency of this package. Thank you. |
|
@jonathantneal can this be merged or are more test required? |
|
Note: the postcss-import issue stems from postcss-import@latest not importing files without .scss at the end of the file name. E.g. // This is required at the end of an import for postcss-import to work properly
@import "components.scss";
To fix this problem in my PR I changed the order of the postcss plug-ins and had postcss-scss run first, and then postcss-import. |
|
Please release ! |
|
Hi. I can confirm that all issues have been resolved with this PR. Here is my fork: https://github.com/sinankeskin/postcss-sass You can release confidently. Thank you. |
|
Is there any update on releasing this PR? I guess the only thing left is to bump the version? Thanks! Think it has to be a repository owner |
I guess he is not available right now. While waiting to release you use my fork with |
|
Thanks, @sinankeskin. Didn't realise it was distributable like that |
|
@jonathantneal any news on the release? It would be great if we could use sass with PostCSS 8. :) |
postcss-import@latest doesn't seem to import without .scss at the end