Skip to content

Conversation

@okikio
Copy link
Contributor

@okikio okikio commented Jan 14, 2021

  • support postcss 8
  • fix bugs in tests (I found some inconsistencies);
  • update dependencies;
  • update rollup build process

postcss-import@latest doesn't seem to import without .scss at the end

support postcss 8; fix bugs in tests; upate deps; update build process

postcss-import@latest doesn't seem to  import without .scss
@okikio okikio changed the title refactor: 🎨 add support for postcss 8 & update dependencies update: add support for postcss 8 & update dependencies Jan 14, 2021
postcss 8 & rollup prefers node v12+
@sinankeskin
Copy link

Any news on this PR?

Latest version autoprefixer throws an error because of the postcss 7 dependency of this package.

Thank you.

@okikio
Copy link
Contributor Author

okikio commented Jan 21, 2021

@jonathantneal can this be merged or are more test required?

@okikio
Copy link
Contributor Author

okikio commented Jan 21, 2021

Note: the postcss-import issue stems from postcss-import@latest not importing files without .scss at the end of the file name.

E.g.

// This is required at the end of an import for postcss-import to work properly
@import "components.scss";

To fix this problem in my PR I changed the order of the postcss plug-ins and had postcss-scss run first, and then postcss-import.

@majo44
Copy link

majo44 commented Jan 28, 2021

Please release !

@sinankeskin
Copy link

sinankeskin commented Feb 7, 2021

Hi.

I can confirm that all issues have been resolved with this PR. Here is my fork: https://github.com/sinankeskin/postcss-sass

You can release confidently.

Thank you.

@amprew
Copy link

amprew commented Mar 8, 2021

Is there any update on releasing this PR? I guess the only thing left is to bump the version? Thanks!

Think it has to be a repository owner

@sinankeskin
Copy link

Is there any update on releasing this PR? I guess the only thing left is to bump the version? Thanks!

Think it has to be a repository owner

I guess he is not available right now.

While waiting to release you use my fork with npm i https://github.com/sinankeskin/postcss-sass.git

@amprew
Copy link

amprew commented Mar 8, 2021

Thanks, @sinankeskin. Didn't realise it was distributable like that

@jonathantneal jonathantneal merged commit 3e232b6 into csstools:master Mar 8, 2021
@miguelcobain
Copy link

@jonathantneal any news on the release? It would be great if we could use sass with PostCSS 8. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants