Skip to content

Search capability#122

Merged
dawidd6 merged 11 commits into
dawidd6:masterfrom
martcus:master
Nov 23, 2021
Merged

Search capability#122
dawidd6 merged 11 commits into
dawidd6:masterfrom
martcus:master

Conversation

@martcus

@martcus martcus commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

For those who need to find a certain artifact knowing only its name.

@martcus

martcus commented Nov 19, 2021

Copy link
Copy Markdown
Contributor Author

my apologies, now all checks have passed

@dawidd6 dawidd6 self-assigned this Nov 19, 2021
@fs24-chrter

Copy link
Copy Markdown

That's a nice addition 👍

@Schuchie

Copy link
Copy Markdown

This is the missing changes, which would help me significantly! Thx for sharing! :)

@Schuchie

Schuchie commented Nov 22, 2021

Copy link
Copy Markdown

@dawidd6 check_artifacts did not work on my pipeline. It did not found the artifact which was created by an older run.

Edit: I saw the PR from https://github.com/dawidd6/action-download-artifact/pull/88/files : I think they only download the artifact from the latest Workflow, but not older ones. Thats why this change is different.

@martcus

martcus commented Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

This change allows you to identify and download an artifact based on its name (useful when, for example, you store artifacts with the version name).

from my analysis, the check_artifacts downloads the latest available artifact.

@dawidd6

dawidd6 commented Nov 22, 2021

Copy link
Copy Markdown
Owner

Change the input to be a boolean, we already have name input.

@martcus

martcus commented Nov 23, 2021

Copy link
Copy Markdown
Contributor Author

Changed. Thanks

@dawidd6 dawidd6 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked the logic a bit. Thanks.

@dawidd6 dawidd6 merged commit 09385b7 into dawidd6:master Nov 23, 2021
Ma-ve pushed a commit to Ma-ve/action-download-artifact-with-retry that referenced this pull request Jun 24, 2025
Co-authored-by: martcus <marco.lovazzano@accenture.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants