Skip to content

Attempt to ensure that we download the latest artifact#241

Closed
dsnopek wants to merge 2 commits into
dawidd6:masterfrom
dsnopek:latest-workflow-run-for-repo
Closed

Attempt to ensure that we download the latest artifact#241
dsnopek wants to merge 2 commits into
dawidd6:masterfrom
dsnopek:latest-workflow-run-for-repo

Conversation

@dsnopek

@dsnopek dsnopek commented Apr 29, 2023

Copy link
Copy Markdown

This fixes issue #240 for me!

When switching from 'listWorkflowRuns' to the 'listWorkflowRunsForRepo' end-point, it's returning the workflow runs in reverse chronological order (ie. newest to oldest), which means that newer artifacts are favored over older ones.

@dsnopek

dsnopek commented Apr 29, 2023

Copy link
Copy Markdown
Author

Hm, unfortunately, it looks like there's one test failure :-/

@dsnopek

dsnopek commented May 17, 2023

Copy link
Copy Markdown
Author

Testing this for a little while, it seems to occasionally still pull an artifact that's a couple days old, even though there may be like ~40 newer ones. Adding a new 'ensure_latest' configuration has seemed to fix it in early testing - let's see how this goes!

@dsnopek dsnopek changed the title Switch from 'listWorkflowRuns' to 'listWorkflowRunsForRepo' end-point Attempt to ensure that we download the latest artifact May 17, 2023
@dawidd6

dawidd6 commented May 17, 2023

Copy link
Copy Markdown
Owner

There is still some regression here. Look at the failed job. Any ideas?

@JacksonBurns

JacksonBurns commented Jun 8, 2023

Copy link
Copy Markdown

We have also run into this issue here.

This turned out to be user error on our part, I have no comment on the issue at hand.

@dawidd6

dawidd6 commented Aug 11, 2023

Copy link
Copy Markdown
Owner

@dsnopek are you still working on that?

@ofek

ofek commented Sep 16, 2023

Copy link
Copy Markdown

Can this be picked up again?

@alberthli

Copy link
Copy Markdown

+1 on wanting this feature!

@lucentlabz lucentlabz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@dawidd6 dawidd6 added help wanted Extra attention is needed good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 4, 2024
@dawidd6

dawidd6 commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Superseded by #398 I guess. Thank you.

@dawidd6 dawidd6 closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants