Skip to content

add merge_multiple option#327

Merged
dawidd6 merged 1 commit into
dawidd6:masterfrom
timostroehlein:merge-multiple
Feb 20, 2025
Merged

add merge_multiple option#327
dawidd6 merged 1 commit into
dawidd6:masterfrom
timostroehlein:merge-multiple

Conversation

@timostroehlein

Copy link
Copy Markdown
Contributor

Add merge_multiple option to download all artifacts into the same folder. Essentially does the same as the merge-multiple option from the official download action
https://github.com/actions/download-artifact?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory

@dawidd6

dawidd6 commented Feb 20, 2025

Copy link
Copy Markdown
Owner

Nice. Thanks!

@dawidd6 dawidd6 merged commit 07ab29f into dawidd6:master Feb 20, 2025
@timostroehlein timostroehlein deleted the merge-multiple branch February 27, 2025 09:33
@timostroehlein

Copy link
Copy Markdown
Contributor Author

@dawidd6 Could you release a new version with this change, I would highly appreciate it :)

@dawidd6

dawidd6 commented Feb 27, 2025

Copy link
Copy Markdown
Owner

Right away sir. Released in v9.

@mstorsjo

Copy link
Copy Markdown
Contributor

This seems to use the spelling merge_multiple, whereas https://github.com/actions/download-artifact uses the spelling merge-multiple. Is this divergence intentional?

Also, this option isn't documented in the main option listing at https://github.com/dawidd6/action-download-artifact?tab=readme-ov-file#usage.

Ma-ve pushed a commit to Ma-ve/action-download-artifact-with-retry that referenced this pull request Jun 24, 2025
@timostroehlein

Copy link
Copy Markdown
Contributor Author

This seems to use the spelling merge_multiple, whereas https://github.com/actions/download-artifact uses the spelling merge-multiple. Is this divergence intentional?

Also, this option isn't documented in the main option listing at https://github.com/dawidd6/action-download-artifact?tab=readme-ov-file#usage.

The spelling is intentional since all options in this action are named using snake case and this really shouldn't be mixed up. I've created a PR to update the readme, thanks for pointing that out

@mstorsjo

mstorsjo commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

This seems to use the spelling merge_multiple, whereas https://github.com/actions/download-artifact uses the spelling merge-multiple. Is this divergence intentional?
Also, this option isn't documented in the main option listing at https://github.com/dawidd6/action-download-artifact?tab=readme-ov-file#usage.

The spelling is intentional since all options in this action are named using snake case and this really shouldn't be mixed up. I've created a PR to update the readme, thanks for pointing that out

Fair enough, that's a reasonable argument. Thanks for adding the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants