Skip to content

Fix octokit returning weird results from listWorkflowRuns#95

Merged
dawidd6 merged 4 commits into
dawidd6:masterfrom
erd0s:master
Aug 4, 2021
Merged

Fix octokit returning weird results from listWorkflowRuns#95
dawidd6 merged 4 commits into
dawidd6:masterfrom
erd0s:master

Conversation

@erd0s

@erd0s erd0s commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

This is the gist, what you think?

@erd0s erd0s mentioned this pull request Aug 4, 2021
Closed
vmirkin-proag
vmirkin-proag reviewed Aug 4, 2021
View reviewed changes
Comment thread main.js Outdated
Comment thread main.js Outdated
@dawidd6

dawidd6 commented Aug 4, 2021

Copy link
Copy Markdown
Owner

Ok. This is not working as expected and I guess the data returned from GitHub contains wrong statuses of workflow runs but I have to check those yet

@erd0s

erd0s commented Aug 4, 2021

Copy link
Copy Markdown
Contributor Author

@dawidd6 this change erd0s@6f3720f will stop you from being able to do "completed,success" right? Just one of the two?

@dawidd6

dawidd6 commented Aug 4, 2021

Copy link
Copy Markdown
Owner

Yep. According to API docs completed is automatically assumed when specifying status. I think I read that right.

@erd0s

erd0s commented Aug 4, 2021

Copy link
Copy Markdown
Contributor Author

Maybe like this? erd0s@9073df9, also taking into account comments from @vmirkin-proag

@dawidd6 dawidd6 merged commit 6f8f427 into dawidd6:master Aug 4, 2021
@dawidd6

dawidd6 commented Aug 4, 2021

Copy link
Copy Markdown
Owner

Fixed, thanks

@vnaidin

vnaidin commented Aug 4, 2021 •
edited
Loading

Copy link
Copy Markdown

Hello guys, after fix it finds the oldest successful workflow run..., and according to my settings github automatically deletes such old artifacts. Can you have a look again?
P.s: added the last successful run_id manually => obviously works , but if I state branch:master instead, it fails...

sscott1-godaddy added a commit to gdcorp-action-public-forks/action-download-artifact that referenced this pull request Sep 16, 2021
@sscott1-godaddy @nickthegroot
@dawidd6 @erd0s @shitlsh
Merge upstream changes (#10)
7455d28 
* Add pagination when listing all artifacts (dawidd6#90)

Co-authored-by: Nick DeGroot <1966472+nickthegroot@users.noreply.github.com>

* main: remove ';'

* README: fix

* main: throw if no runID

* action: only success

* README: update

* workflows: test empty conclusion

* Fix octokit returning weird results from listWorkflowRuns (dawidd6#95)

Closes: dawidd6#93 

Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>

* README: remove stray dot

* download aritfact from latest run which upload an artifact (dawidd6#88)

Co-authored-by: Nick DeGroot <nbdegroot1@gmail.com>
Co-authored-by: Nick DeGroot <1966472+nickthegroot@users.noreply.github.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Dirk <dirks@seatfrog.com>
Co-authored-by: Tailong <54169577+shitlsh@users.noreply.github.com>
@dawidd6 dawidd6 mentioned this pull request Aug 11, 2023
Open
Ma-ve pushed a commit to Ma-ve/action-download-artifact-with-retry that referenced this pull request Jun 24, 2025
@erd0s @dawidd6
Fix octokit returning weird results from listWorkflowRuns (dawidd6#95)
fa4fac9 
Closes: dawidd6#93 

Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vmirkin-proag vmirkin-proag vmirkin-proag left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erd0s @dawidd6 @vnaidin @vmirkin-proag