Skip to content

Only import a module's stylesheet the first time a module is seen in the tree. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2013

Conversation

techwraith
Copy link
Contributor

No description provided.

@techwraith
Copy link
Contributor Author

This is just a start, I'll be adding tests and trying to break it later this week. I just wanted to start the conversation early to make sure I'm going in a good direction.

@techwraith
Copy link
Contributor Author

Also, just for reference, I'll leave this here:

solves #6

@techwraith
Copy link
Contributor Author

Any thoughts on this one?

@techwraith
Copy link
Contributor Author

Just pushed an update that I think will be the final one, unless you can think of a way to remove the @import statements that are duplicates...

@techwraith
Copy link
Contributor Author

How is that?

@defunctzombie
Copy link
Owner

Looks, good. Can we add a test for this?

@techwraith
Copy link
Contributor Author

Sure, what do I need to do to get the tests to run? I get not ok 2 Error: Cannot find module 'foobar' right now when I run them.

@defunctzombie
Copy link
Owner

I'll take a look. Been a while since I poked at it :)
On Aug 7, 2013 6:31 PM, "Daniel Erickson" notifications@github.com wrote:

Sure, what do I need to do to get the tests to run? I get not ok 2 Error:
Cannot find module 'foobar' right now when I run them.


Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-22296806
.

@techwraith
Copy link
Contributor Author

Also, should we comment out the duplicate @import statements? If so, any advice on doing so?

@techwraith
Copy link
Contributor Author

Any progress on this?

@techwraith
Copy link
Contributor Author

One more bump.

@defunctzombie
Copy link
Owner

I haven't forgotten about this, just been preoccupied with other things.

@techwraith
Copy link
Contributor Author

No problem, I'm just making sure ;)

We're waiting on this pull request before we put this into production at
work.

On Wednesday, August 21, 2013, Roman Shtylman wrote:

I haven't forgotten about this, just been preoccupied with other things.


Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-23003145
.

defunctzombie added a commit that referenced this pull request Sep 1, 2013
Only import a module's stylesheet the first time a module is seen in the tree.
@defunctzombie defunctzombie merged commit e080fa2 into defunctzombie:master Sep 1, 2013
@techwraith
Copy link
Contributor Author

Awesome, thanks for this! I've updated atomify to reflect this. Now all of our CSS can name it's own deps and all is right with the world :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants