-
Notifications
You must be signed in to change notification settings - Fork 8
Only import a module's stylesheet the first time a module is seen in the tree. #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is just a start, I'll be adding tests and trying to break it later this week. I just wanted to start the conversation early to make sure I'm going in a good direction. |
Also, just for reference, I'll leave this here: solves #6 |
Any thoughts on this one? |
Just pushed an update that I think will be the final one, unless you can think of a way to remove the @import statements that are duplicates... |
How is that? |
Looks, good. Can we add a test for this? |
Sure, what do I need to do to get the tests to run? I get |
I'll take a look. Been a while since I poked at it :)
|
Also, should we comment out the duplicate @import statements? If so, any advice on doing so? |
Any progress on this? |
One more bump. |
I haven't forgotten about this, just been preoccupied with other things. |
No problem, I'm just making sure ;) We're waiting on this pull request before we put this into production at On Wednesday, August 21, 2013, Roman Shtylman wrote:
|
Only import a module's stylesheet the first time a module is seen in the tree.
Awesome, thanks for this! I've updated atomify to reflect this. Now all of our CSS can name it's own deps and all is right with the world :) |
No description provided.