Skip to content

fix get fallback#421

Open
easonyq wants to merge 1 commit intodefunkt:masterfrom
easonyq:master
Open

fix get fallback#421
easonyq wants to merge 1 commit intodefunkt:masterfrom
easonyq:master

Conversation

@easonyq
Copy link

@easonyq easonyq commented Aug 4, 2014

This fix a problem when GET method comes to fallbackPjax.
Usually in GET method, we tend to use

{
    url: '/?a=1&b=2'
} 

rather than

{
    url: '/', 
    data: 'a=1&b=2'
}

But any parameters written in action attribute of <form> element with GET method will be ignored.
e.g.

<form action="/?a=1&b=2" method='GET'>

is equivalent to

<form action="/' method='GET'>

Thus we need to add these parameters using hidden input.

@mislav
Copy link
Collaborator

mislav commented Sep 15, 2014

Thanks. I'd like to see a failing test for this first that this commit fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants