Add blurFocus option to disable bluring the focus of existing elements.#545
Merged
mislav merged 1 commit intodefunkt:masterfrom Jul 21, 2015
Merged
Add blurFocus option to disable bluring the focus of existing elements.#545mislav merged 1 commit intodefunkt:masterfrom
mislav merged 1 commit intodefunkt:masterfrom
Conversation
Collaborator
|
See #378 (comment) I wouldn't add a configuration option. I would rather add a condition that elements should only get blurred/refocused if inside the pjax container. |
Author
jquery.pjax.js
Outdated
Contributor
There was a problem hiding this comment.
Shouldnt we also defer this DOM operation to only evaluate when blurFocus is true?
Collaborator
|
Thanks! Please squash all commits to one and force-push to this branch |
This can be useful if using PJAX to reload the contents of a search page, for instance. See defunkt#377
Author
|
@mislav Done. PTAL. |
mislav
added a commit
that referenced
this pull request
Jul 21, 2015
Add blurFocus option to disable bluring the focus of existing elements.
Collaborator
|
Thanks! |
Author
|
I really appreciate your timely responses @mislav; thanks for the hard work! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a
blurFocusoption that disables the focus blurring that occurs on existing elements when loading content. This can be useful if using PJAX to reload the contents of a search page, for instance.Multiple other people requested this feature back in 2013 when the blurring was introduced, and additionally so on a fork of your project.