chore(zbugs): tighten up types on enumerations (rocicorp#4472)

tantaman · web-flow · commit 65c989f77d22 · 2025-06-07T10:59:37.000-04:00
diff --git a/apps/zbugs/shared/auth.ts b/apps/zbugs/shared/auth.ts
@@ -14,6 +14,7 @@ export const authDataSchema = v.object({
 });
 
 export type AuthData = v.Infer<typeof authDataSchema>;
+export type Role = AuthData['role'];
 
 export function assertIsLoggedIn(
   authData: AuthData | undefined,
diff --git a/apps/zbugs/shared/schema.ts b/apps/zbugs/shared/schema.ts
@@ -11,7 +11,7 @@ import {
   type ExpressionBuilder,
   type Row,
 } from '@rocicorp/zero';
-import type {AuthData} from './auth.ts';
+import type {AuthData, Role} from './auth.ts';
 
 // Table definitions
 const user = table('user')
@@ -20,7 +20,7 @@ const user = table('user')
     login: string(),
     name: string().optional(),
     avatar: string(),
-    role: enumeration<'user' | 'crew'>(),
+    role: enumeration<Role>(),
   })
   .primaryKey('id');
 
@@ -35,7 +35,7 @@ const issue = table('issue')
     creatorID: string(),
     assigneeID: string().optional(),
     description: string(),
-    visibility: string(),
+    visibility: enumeration<'internal' | 'public'>(),
   })
   .primaryKey('id');
 
diff --git a/apps/zbugs/src/pages/issue/issue-page.tsx b/apps/zbugs/src/pages/issue/issue-page.tsx
@@ -543,7 +543,7 @@ export function IssuePage({onReady}: {onReady: () => void}) {
           {login.loginState?.decoded.role === 'crew' ? (
             <div className="sidebar-item">
               <p className="issue-detail-label">Visibility</p>
-              <Combobox
+              <Combobox<'public' | 'internal'>
                 editable={false}
                 disabled={!canEdit}
                 items={[
