Feature-flag gate stopSurface on root view unmount

JoshuaGross · facebook-github-bot · commit b69041f086ac · 2020-06-15T18:43:30.000-07:00
Summary:
Gate stopSurface behind a feature flag.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D22054480

fbshipit-source-id: 3ea48ab46aeb3532fc7a3dd83659d7c32891ec06
diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
@@ -39,6 +39,7 @@
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.bridge.WritableNativeMap;
 import com.facebook.react.common.annotations.VisibleForTesting;
+import com.facebook.react.config.ReactFeatureFlags;
 import com.facebook.react.modules.appregistry.AppRegistry;
 import com.facebook.react.modules.core.DeviceEventManagerModule;
 import com.facebook.react.modules.deviceinfo.DeviceInfoModule;
@@ -437,13 +438,14 @@ public void unmountReactApplication() {
     // to be committed via the Scheduler, which will cause mounting instructions
     // to be queued up and synchronously executed to delete and remove
     // all the views in the hierarchy.
-    if (mReactInstanceManager != null) {
+    if (mReactInstanceManager != null && ReactFeatureFlags.enableStopSurfaceOnRootViewUnmount) {
       final ReactContext reactApplicationContext = mReactInstanceManager.getCurrentReactContext();
       if (reactApplicationContext != null && getUIManagerType() == FABRIC) {
         @Nullable
         UIManager uiManager =
             UIManagerHelper.getUIManager(reactApplicationContext, getUIManagerType());
         if (uiManager != null) {
+          FLog.e(TAG, "stopSurface for surfaceId: " + this.getId());
           uiManager.stopSurface(this.getId());
         }
       }
diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
@@ -89,4 +89,7 @@ public class ReactFeatureFlags {
 
   /** Feature flag to have FabricUIManager teardown stop all active surfaces. */
   public static boolean enableFabricStopAllSurfacesOnTeardown = false;
+
+  /** Feature flag to use stopSurface when ReactRootView is unmounted. */
+  public static boolean enableStopSurfaceOnRootViewUnmount = false;
 }

Original file line number	Diff line number	Diff line change
`@@ -89,4 +89,7 @@ public class ReactFeatureFlags {`
`89`	`89`
`90`	`90`	`/** Feature flag to have FabricUIManager teardown stop all active surfaces. */`
`91`	`91`	`public static boolean enableFabricStopAllSurfacesOnTeardown = false;`
	`92`	`+`
	`93`	`+ /** Feature flag to use stopSurface when ReactRootView is unmounted. */`
	`94`	`+ public static boolean enableStopSurfaceOnRootViewUnmount = false;`
`92`	`95`	`}`