Commits

Branch selector

 master

User selector

JoshuaGross

All time

Commit History

Commits on Jun 16, 2020

• Feature-flag gate stopSurface on root view unmount

  Show description for b69041f
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  b69041f

  Copy full SHA for b69041f

• Bust `surfaceActiveForExecution` cache after executing a batch of items

  Show description for 33ed358
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  33ed358

  Copy full SHA for 33ed358

• LayoutAnimations: fix crashes

  Show description for e0294af
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  e0294af

  Copy full SHA for e0294af

Commits on Jun 14, 2020

• Avoid using ViewManager childCount to detect errors, since it's not reliable

  Show description for 86c3873
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  86c3873

  Copy full SHA for 86c3873

Commits on Jun 12, 2020

• For lifecycle correctness, call scheduleMountItems even with empty BatchMountItem

  Show description for 40b36a0
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  40b36a0

  Copy full SHA for 40b36a0

• Fix typos in Native Animated error messages

  Show description for 0d07301
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  0d07301

  Copy full SHA for 0d07301

• AnimatedDivision: pass zero instead of Inf/NaN in case of division by zero

  Show description for 23f2ec7
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  23f2ec7

  Copy full SHA for 23f2ec7

• NativeAnimatedDriver: synchronize animation lifecycle closer to Fabric or Paper lifecycle

  Show description for 472cf3f
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  472cf3f

  Copy full SHA for 472cf3f

Commits on Jun 10, 2020

• BatchMountItem debug info should log SurfaceId

  Show description for 02b8e67
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  02b8e67

  Copy full SHA for 02b8e67

• Ignore PreAllocateViewMountItem if it's associated with a stopped surface

  Show description for 912dac2
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  912dac2

  Copy full SHA for 912dac2

• Call stopSurface when ReactRootView is unregistered

  Show description for 03174f1
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  03174f1

  Copy full SHA for 03174f1

Commits on Jun 9, 2020

• ScrollViewStickyHeader: update position (translateY) in Fabric ShadowTree when scrolling stops

  Show description for fa5d3fb
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  fa5d3fb

  Copy full SHA for fa5d3fb

Commits on Jun 6, 2020

• Do not execute MountItems if their associated Surface has been stopped

  Show description for 8b47e69
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  8b47e69

  Copy full SHA for 8b47e69

• FabricUIManager: clear out mReactContextForRootTag when stopSurface is called

  Show description for b6fedfe
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  b6fedfe

  Copy full SHA for b6fedfe

• Refactor how synchronous updates are queued and executed in FabricUIManager

  Show description for d821a9f
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  d821a9f

  Copy full SHA for d821a9f

Commits on May 29, 2020

• Fix crash in NativeAnimatedModule due to inlining and race between animation/teardown

  Show description for 5d39bfa
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  5d39bfa

  Copy full SHA for 5d39bfa

• Stop all surfaces when tearing down FabricUIManager

  Show description for 8a02450
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  8a02450

  Copy full SHA for 8a02450

• Remove logs related to T62192299

  Show description for 983b0a0
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  983b0a0

  Copy full SHA for 983b0a0

• Delete ReactViewPager

  Show description for f438a6e
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  f438a6e

  Copy full SHA for f438a6e

• Delete ViewPagerAndroid JS and BUCK targets

  Show description for 3148d17
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  3148d17

  Copy full SHA for 3148d17

Commits on May 28, 2020

• Back out "Reset RootView ID when root view is detached from view hierarchy"

  Show description for 5cde6c5
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  5cde6c5

  Copy full SHA for 5cde6c5

• Fix crash in removeViewAt by fixing incorrect error-detection

  Show description for 8da92d7
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  8da92d7

  Copy full SHA for 8da92d7

Commits on May 27, 2020

• Fix crash introduced by D21735940 in T67525923

  Show description for 7e55946
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  7e55946

  Copy full SHA for 7e55946

• Reset RootView ID when root view is detached from view hierarchy

  Show description for bd31416
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  bd31416

  Copy full SHA for bd31416

• Better error message when crashing because of an invalid Remove operation

  Show description for 1a77943
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  1a77943

  Copy full SHA for 1a77943

Commits on May 26, 2020

• C++ LayoutAnimations: solve crash when "animating" virtual views

  Show description for 8b2eb37
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  8b2eb37

  Copy full SHA for 8b2eb37

• LayoutAnimations: fail silently instead of redboxing if there's a misconfigured LayoutAnimation

  Show description for ae7df2d
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  ae7df2d

  Copy full SHA for ae7df2d

• Fix NativeAnimatedModule timing for Fabric/Venice(?)

  Show description for 8e13480
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  8e13480

  Copy full SHA for 8e13480

• Android Animated timing: interface-only

  Show description for 0b00d92
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  0b00d92

  Copy full SHA for 0b00d92

Commits on May 21, 2020

• LayoutAnimations: allow Paragraph props to be interpolated

  Show description for c75e8ae
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  c75e8ae

  Copy full SHA for c75e8ae

• LayoutAnimations: Use Quaternions to interpolate rotation transforms

  Show description for 3f9fad1
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  3f9fad1

  Copy full SHA for 3f9fad1

• iOS-specific LayoutAnimation integration

  Show description for 73995cf
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  73995cf

  Copy full SHA for 73995cf

• Android-specific LayoutAnimation integration

  Show description for 483f84e
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  483f84e

  Copy full SHA for 483f84e

• LayoutAnimations: implement LayoutAnimationStatusDelegate for platform-specific integrations

  Show description for eb9b2ce
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  eb9b2ce

  Copy full SHA for eb9b2ce

• LayoutImplementations: implement all existing animation curves besides Keyboard

  Show description for 8d2c1f6
  

  JoshuaGross

  authored and

  facebook-github-bot

  committed
  8d2c1f6

  Copy full SHA for 8d2c1f6