Skip to content

Commit ca144fc

Browse files
JoshuaGrossfacebook-github-bot
authored andcommitted
Fix unit test compilation on Android
Summary: Before, compilation fails with P130281113. After fixing BUCK target, fails with P130281201. After all changes, the tests succeed. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D21390996 fbshipit-source-id: c85aa43b3ef7fc9642d226ae706c937b2a5a408d
1 parent 30a89f3 commit ca144fc

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

ReactCommon/fabric/mounting/BUCK

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ fb_xplat_cxx_test(
7676
"-Wall",
7777
],
7878
contacts = ["oncall+react_native@xmail.facebook.com"],
79+
fbandroid_use_instrumentation_test = True,
7980
platforms = (ANDROID, APPLE, CXX),
8081
deps = [
8182
":mounting",

ReactCommon/fabric/mounting/tests/ShadowTreeLifeCycleTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,9 @@ static void testShadowNodeTreeLifeCycle(
114114

115115
LOG(ERROR) << "Entropy seed: " << entropy.getSeed() << "\n";
116116

117+
// There are some issues getting `getDebugDescription` to compile
118+
// under test on Android for now.
119+
#ifndef ANDROID
117120
LOG(ERROR) << "Shadow Tree before: \n"
118121
<< currentRootNode->getDebugDescription();
119122
LOG(ERROR) << "Shadow Tree after: \n"
@@ -128,6 +131,7 @@ static void testShadowNodeTreeLifeCycle(
128131
LOG(ERROR) << "Mutations:"
129132
<< "\n"
130133
<< getDebugDescription(mutations, {});
134+
#endif
131135

132136
FAIL();
133137
}

0 commit comments

Comments
 (0)