Use height of items to compute heightDelta #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkirda
pushed a commit
that referenced
this pull request
Sep 25, 2014
Use height of items to compute heightDelta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case
When using a list with a fixed height set to show an exact number of suggestions, it creates a much better effect if the list scrolls by exactly the height of one suggestion when you use the cursor keys to scroll through.
Examples
Before: Using fixed value of
heightDelta: 25last element is cut offAfter: Using automatically calculated value of
heightDelta: 43Thanks for an awesome plugin by the way! 👍