Skip to content

Empty input (all spaces) shouldn't be counted in minChars limit #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisalferoz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Empty input (all spaces) shouldn't be counted in minChars limit #850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c00c94
Empty input (all spaces) isn't counted in minChars
Oct 20, 2022
5aa5a69
Excludes non alphanumeric characters from minChars check
Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Empty input (all spaces) isn't counted in minChars
  • Loading branch information
Faisal Feroz committed Oct 20, 2022
commit 1c00c94a7860ace3e5ecce3cc6bded7649b293a1
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
/*.xml
/bower_components
/node_modules/*
.DS_Store
package-lock.json
4 changes: 2 additions & 2 deletions dist/jquery.autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@

that.fixPosition();

if (that.el.val().length >= that.options.minChars) {
if (that.el.val().trim().length >= that.options.minChars) {
that.onValueChange();
}
},
Expand Down Expand Up @@ -493,7 +493,7 @@
return;
}

if (query.length < options.minChars) {
if (query.trim().length < options.minChars) {
that.hide();
} else {
that.getSuggestions(query);
Expand Down
Loading