DNS features needed for Oh-My-Vagrant#145
Open
purpleidea wants to merge 2 commits intodevopsgroup-io:masterfrom
Open
DNS features needed for Oh-My-Vagrant#145purpleidea wants to merge 2 commits intodevopsgroup-io:masterfrom
purpleidea wants to merge 2 commits intodevopsgroup-io:masterfrom
Conversation
This is needed on some systems so that: hostname --fqdn and facter -p | grep fqdn both return something useful. This patch adds the fqdn_friendly and domain_name configuration options.
This is necessary if you want to add a VIP to each host, or if you want to define a host that isn't part of your vagrant infrastructure, but which needs to be listed in your "DNS".
|
Hi there, I really would like to see this merge as it blocks some of the Atomic Host stuff we are doing. Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I think I let this patch stay idle for a while, and it's now back in my more pressing issues TODO list.
It started in: #109 and #111
It's now been updated to be rebased against current git master.
Please have a look and hopefully merge.
It works with the oh-my-vagrant branch: https://github.com/purpleidea/oh-my-vagrant/tree/feat/hostmanager
If you don't like this patch as is, or if there is something that you think should be done differently, if you could propose/merge those changes so I can use them in oh-my-vagrant, that would be great.
Thanks,
James