Skip to content

Fix recursive dependency and large dist files #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2017
Merged

Fix recursive dependency and large dist files #8

merged 1 commit into from
Sep 22, 2017

Conversation

SBoudrias
Copy link
Contributor

  1. Don't rely on self in the dependency (as you might guess, this creates quite the recursive dependency)
  2. Remove tests/dev files from the package published to npm (.npmignore)
  3. Delete coverage build artifact (I assume they were committed by mistake)

@dielduarte
Copy link
Owner

@SBoudrias WOW! It's a great PR for the project to work better now. Thanks for your time, let me know if you have any more suggestions.

@dielduarte dielduarte merged commit bf30248 into dielduarte:master Sep 22, 2017
@SBoudrias SBoudrias deleted the fix/proper-dependencies-and-dist-size branch September 22, 2017 03:05
@SBoudrias
Copy link
Contributor Author

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBoudrias @dielduarte