Skip to content

Conversation

@SBoudrias
Copy link
Contributor

  1. Don't rely on self in the dependency (as you might guess, this creates quite the recursive dependency)
  2. Remove tests/dev files from the package published to npm (.npmignore)
  3. Delete coverage build artifact (I assume they were committed by mistake)

@dielduarte
Copy link
Owner

@SBoudrias WOW! It's a great PR for the project to work better now. Thanks for your time, let me know if you have any more suggestions.

@dielduarte dielduarte merged commit bf30248 into dielduarte:master Sep 22, 2017
@SBoudrias SBoudrias deleted the fix/proper-dependencies-and-dist-size branch September 22, 2017 03:05
@SBoudrias
Copy link
Contributor Author

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants