This repository was archived by the owner on Dec 11, 2017. It is now read-only.
Added option to allow retention of partially filled in masked fields#102
Closed
earino wants to merge 2 commits intodigitalBush:masterfrom
Closed
Added option to allow retention of partially filled in masked fields#102earino wants to merge 2 commits intodigitalBush:masterfrom
earino wants to merge 2 commits intodigitalBush:masterfrom
Conversation
added 2 commits
November 9, 2012 15:08
… added a test in Focus.Spec.js and then added feature to masked method to allow the passing in of a new option, retainPartial. This should allow for better integration with the jquery validate library, as previously on partially entered data, the field would clear before jQuery Validate had a chance to even test the field's partial value for any sort of correctness.
|
Applied this to the current master, by using the patch`s code where the conflict was. Works as outlined. I suggest adding this as a feature to the great plugin. It's configurable after all, and the benefits in some UX cases are enormous. |
Owner
|
Cleaning up some old pull requests. Thank you for taking the time to submit this. This looks similar to the functionality that we merged in with #183. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Cakefile so it would not complain about out of support stuff, added a test in Focus.Spec.js and then added feature to masked method to allow the passing in of a new option, retainPartial. This should allow for better integration with the jquery validate library, as previously on partially entered data, the field would clear before jQuery Validate had a chance to even test the field's partial value for any sort of correctness.
Basically, we have fields that have remote validation rules, and they are masked. If the person left the field before the mask was fully filled in, it cleared it, never gave a chance for our remote validation rules to do anything interesting! This should hopefully fix it!