This repository was archived by the owner on Dec 11, 2017. It is now read-only.
Closed
Conversation
Signed-off-by: fwosko <fwosko@gmail.com>
Signed-off-by: fwosko <fwosko@gmail.com>
Owner
|
Curious, why are you masking a textarea instead of an regular input? |
Collaborator
There was a problem hiding this comment.
would you mind removing these lines if they're not needed?
Author
|
@digitalBush I'm using your library to make masked input in the handsontable ( https://github.com/warpech/jquery-handsontable ). Form some reasons there is used TEXTAREA as cell editor even if it behaves as INPUT. @codeimpossible Yes, the marked lines can be removed. I inserted them into block comment for future reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for great piece of code that save my time.
When I attached it to my code, my users which uses old IE8 reported that masked input doesn't work. I used your code to mask TEXTAREA. Surprising in IE8 maskedinput works with INPUT's, but breaks on TEXTAREA. I looked into your code and prepared a fix and IE8.Spec.js test case.
Thanks,
Filip