Fallback to event.keyCode for firefox#247
Conversation
|
@patrickkettner thanks for the submission! The changes in the src/jquery.maskedInput.js look fine, however, there are a ton of changes to the javascript in the dist folder. The dist folder is really only updated when we release a new version. All code modifications should be done to the javascript in the src/ folder, and only changes to the src/ folder should be submitted in a PR. Can you move your changes from dist/ to src/ and re-submit? |
95b7ac2 to
7f28b66
Compare
|
done! |
fixes #199
7f28b66 to
c1f485d
Compare
|
rebased off of latest master as well |
Fallback to event.keyCode for firefox
|
@codeimpossible one should remove dist folder from source control and add into $ git add build -fjQuery has a pattern to automate this using grunt release process (but I never digged deeper into it). |
|
Good idea on the dist folder. I've been rebuilding that thing every push just so people have a version they can test the changes. Hopefully we can get on a more sane release cycle and make this a non-issue. |
fixes #199