This repository was archived by the owner on Dec 11, 2017. It is now read-only.
Clear buffer when shifting characters to the left#256
Merged
digitalBush merged 1 commit intodigitalBush:masterfrom Oct 8, 2014
angelanicholas:bug-clear-buffer-after-shifting-chars
Merged
Clear buffer when shifting characters to the left#256digitalBush merged 1 commit intodigitalBush:masterfrom angelanicholas:bug-clear-buffer-after-shifting-chars
digitalBush merged 1 commit intodigitalBush:masterfrom
angelanicholas:bug-clear-buffer-after-shifting-chars
Conversation
digitalBush
added a commit
that referenced
this pull request
Oct 8, 2014
…hars Clear buffer when shifting characters to the left
Owner
|
Awesome! Thanks you for the test @akn102! |
This was referenced Oct 8, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where if you type characters at the end of an input mask with autoclear set to false and then blur/focusout, the typed characters are shifted to the beginning of the mask (left) but then also duplicated at their original typed position... resulting in some wacky entries like "(44_) ___ - __44". Further focusing / blurring on the input field would repeat this strange duplication + shifting issue.
This fix duplicates the solution found in #175 and adds a test.
Now, we're clearing the buffer (removing trailing characters) if your cursor position is greater than the length of your input after the characters have been shifted left.