Skip to content
This repository was archived by the owner on Dec 11, 2017. It is now read-only.

Android issue with cursor not moving fix#320

Merged
digitalBush merged 2 commits intodigitalBush:masterfrom
MattSich:master
Jun 19, 2015
Merged

Android issue with cursor not moving fix#320
digitalBush merged 2 commits intodigitalBush:masterfrom
MattSich:master

Conversation

@MattSich
Copy link
Contributor

There was an issue where, when typing, the cursor would not move on android. This caused input to be typed backwards. This could be solved if predictive touch was disabled but this was not a good solution. I saw that many people were had the same issue so I decided to fix it. Cheers!

@MattSich
Copy link
Contributor Author

example of someone with the same issue: https://github.com/digitalBush/jquery.maskedinput/issues/280

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the log statement.

@digitalBush
Copy link
Owner

Using the Samsung keyboard, this helps out in Chrome on my S4. Still seeing some issues on the stock browser. Thank yo for the work here. We can merge it once the logging is removed. 👍

@MattSich
Copy link
Contributor Author

@digitalBush log removed

@digitalBush
Copy link
Owner

digitalBush added a commit that referenced this pull request Jun 19, 2015
Android issue with cursor not moving fix
@digitalBush digitalBush merged commit c2f8896 into digitalBush:master Jun 19, 2015
@MattSich
Copy link
Contributor Author

Look at the files changed. It's not in there... I think you're looking at an old version there?

@voronovam
Copy link

hi! can you help me?
i use latest version (1.4.1). but, maskedinput work incorrectly for android...
what need to change in code?


input.caret(pos.begin,pos.begin);
}
function androidInputEvent(e) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 space indents please, not tabs. Never tabs.

@voronovam
Copy link

still NOT WORKING for android - v. 5.1 (sony zt)

@Floppe
Copy link

Floppe commented Apr 15, 2016

Using an Android tablet with Lollipop 5.1.1.

Here it works in Chrome 49, but not in an Android WebView.

@rquadling
Copy link

I had trouble with the use of the maxlength attribute. Removed that and masks worked for me Android.

@dmikester1
Copy link

Github newb here. How do I get this latest version from June 18? It appears it is not the version on the main github page. But it says "merged" up at the top, so I am very confused.

@rquadling
Copy link

@dmikester1 You either have to wait for a new release to be made or you pull from master. If you are using bower then take a read of http://stackoverflow.com/questions/16949173/how-to-install-latest-untagged-state-of-a-repo-using-bower

c-lliope added a commit to codeforamerica/crisisresponse that referenced this pull request Aug 12, 2016
## Problem

We're using [a library to mask the date of birth input][gh].
The latest release, 1.4.1, contains a bug on Android
that causes the input to display backwards.

Officers have found that this bug
renders the date of birth search unusable.

[gh]: https://github.com/digitalBush/jquery.maskedinput,

## Solution

The bug [has been fixed][fix] but the fix has not been released.

To get around this, we're including the fix manually
in the file `vendor/assets/javascripts/jquery.maskedinput.js`.
Once the fix is included in a new release (likely in version 1.4.2),
then we'll be able to load the asset through this Gemfile once again.

[fix]: digitalBush/jquery.maskedinput#320
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants