This repository was archived by the owner on Dec 11, 2017. It is now read-only.
Fixed bug in checkVal() when a mask literal matches a mask regex#46
Closed
codelahoma wants to merge 37 commits intodigitalBush:masterfrom
Closed
Fixed bug in checkVal() when a mask literal matches a mask regex#46codelahoma wants to merge 37 commits intodigitalBush:masterfrom
codelahoma wants to merge 37 commits intodigitalBush:masterfrom
Conversation
added 6 commits
August 2, 2011 16:51
Author
|
Thought I couldn't recreate it, but was working with my corrected version. :-) |
…als that match mask regex
Conflicts: demo/index.html
…kedinput into progressive-reveal
…kedinput into progressive-reveal
Owner
|
Awesome that you got some neat stuff implemented, but there's no way I can merge this PR into master. I have no intentions of porting masked input to coffeescript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pasting a value into a masked input, checkVal() behaved incorrectly if a mask literal character matched any previous mask regex. Couldn't add to the spec tests because it requires pasting to trigger, but you can test manually using an input with mask "$99.00" and pasting a single digit into it.