Skip to content

Regression: Broken inline styles with CSP #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xi opened this issue Mar 16, 2020 · 2 comments · Fixed by #1445
Closed

Regression: Broken inline styles with CSP #1248

xi opened this issue Mar 16, 2020 · 2 comments · Fixed by #1445

Comments

@xi
Copy link
Contributor

xi commented Mar 16, 2020

The applyStyle() function that was removed as "unnecessary" in #1220 had actueally been added in #704 to fix issues with CSP. I suggest to revert #1220.
@matthiask
Copy link
Member

Oh, that was unintentional. Maybe there's a way to avoid the need for inline styles with more CSS classes?

@xi
Copy link
Contributor Author

xi commented Mar 19, 2020

Unfortunately it's not that simple. The inline styles are used mostly for cases where there are many potential values, e.g. the width and offset of bar charts.

See #1249 for a partial solution. I still think a proper fix involved reverting #1220.

@xi xi mentioned this issue Feb 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unsave inline scripts and styles xi/django-debug-toolbar
2 participants
@matthiask @xi