Debug Toolbar broken in the latest Django Trunk

[nemesifier]

Hi everyone,

I just updated my local django trunk and noticed that the django debug toolbar is broken.

TemplateSyntaxError at /
Caught AttributeError while rendering: 'Settings' object has no attribute 'DATABASE_ENGINE'

/var/www/nodeshot-server/debug_toolbar/panels/sql.py in content
'is_mysql': settings.DATABASE_ENGINE == 'mysql',

This is just to inform you about the issue.
For the moment I have disabled the toolbar, I'll try to fix this if I have some spare time.

[thinred]

I cannot confirm that.

I'm using:
1.4 pre-alpha SVN-16824
with the latest master and I see nothing like that. Moreover, I see no line like:

"'is_mysql': settings.DATABASE_ENGINE == 'mysql',

inside my source code.

Are you sure you are using the latest debug toolbar's master? And/or it was a bug inside Django pre 1.4?

Cheers!
Tomek

[nemesifier]

Oh f***, you're right. I have to update my debug toolbar. Even though I follow this repository I forgot to actually update the files :-)
Sorry again.

[rassie]

@thinred: he's using Django trunk, but not debug_toolbar master. 0.8.5 still has this line (#275, sql.py). And it's actually wrong for the hash-based database definition in Django >= 1.3 (or maybe even 1.2).

Good news is probably that a new release of DDTB would fix this.

[thinred]

Oh, I see. Anyway, it's good to check the latest master, isn't it?

[nemesifier]

I downloaded 0.8.5 and I still have the problem.

It's probably because in my settings.py I have

DATABASES = {
'default': {
'ENGINE': 'django.db.backends.mysql', # Add 'postgresql_psycopg2', 'postgresql', 'mysql', 'sqlite3' or 'oracle'.
'NAME': '_', # Or path to database file if using sqlite3.
'USER': '__', # Not used with sqlite3.
'PASSWORD': '_**', # Not used with sqlite3.
'HOST': '', # Set to empty string for localhost. Not used with sqlite3.
'PORT': '', # Set to empty string for default. Not used with sqlite3.
'OPTIONS': {
'init_command': 'SET storage_engine=INNODB',
}
}
}

so the line:

settings.DATABASE_ENGINE == 'mysql'

causes the exception.

This is a possible fix:

debug_toolbar/panels/sql.py line 270

try:
is_mysql = settings.DATABASE_ENGINE == 'mysql'
except AttributeError:
is_mysql = settings.DATABASES['default']['ENGINE'] == 'mysql'

context = self.context.copy()
context.update({
'databases': sorted(self._databases.items(), key=lambda x: -x[1]['time_spent']),
'queries': [q for a, q in self._queries],
'sql_time': self._sql_time,
'is_mysql': is_mysql,
})

[mlavin]

The DATABASE_* settings are set to be removed in Django 1.4 and were removed in r16733.

[nemesifier]

Indeed, that's the problem, the code in my django debug toolbar copy (0.8.5) still looks for DATABASE_ENGINE. The fix I proposed before mantains backward compatibility.

[nemesifier]

The problem is that my fix doesn't deal with multiple databases. So I guess is incomplete.

[pzinovkin]

Same error on fresh installed master while trying to view query explain:

lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "lib/python2.7/site-packages/debug_toolbar/views.py" in sql_explain
  85.         if settings.DATABASE_ENGINE == "sqlite3":
File "lib/python2.7/site-packages/django/utils/functional.py" in inner
  173.         return func(self._wrapped, *args)

Exception Type: AttributeError at /__debug__/sql_explain/
Exception Value: 'Settings' object has no attribute 'DATABASE_ENGINE'