-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Compatible with Django 1.9 #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Try it? |
Hello @aaugustin! Thanks for awesome work on django-debug-toolbar. Unfortunately this doesn't work for me with Django 1.9.7. I'm using Python 3.5 and Django 1.9.7. What is strange when I include into I've got hanging app. Django just freeze forever. When I cancel (Ctrl+C) the django process I got this stacktrace:
It's maybe problem related to django-configurations. Feel free to ask whatever you need to find root cause of this problem. But without debug_toolbar it works fine, so probably this is combination of this issue. |
Uh, annoying. Are you using the "explicit setup" described in the installation instructions? |
No, I'm not using that. |
There's a good chance the explicit setup will resolve the problem that causes this traceback, regardless of the version of Django being use. Apps such as django-configurations are incompatible with the magic setup. |
Hi, I currently use debug-toolbar with django 1.9.7 and Python 3.5 without any issues and manual configurations so it might be collisions with another addons. |
Django debug toolbar is incompatible with Django 1.9 in the automatic mode, because it hangs here:
On the line |
I think the debug toolbar should drop the automagic setup. |
If this suggestion is serious, I have created PR to do so. |
Well... Let's say 80% serious. I actually believe that the automagic setup isn't a tractable concept. But I'm not eager to take responsibility for removing it and deal with frustrated users. |
What about using a deprecation path, similar to Django's strategy? We could deprecate the automatic setup for the next release with a loud warning, and remove in the following (or later) release. |
I personally agree. Because with Django 1.10 automatic setup definitely doesn't work. I suppose because of new style middleware? |
Have problems with automatic setup, but doesn't crash with it. |
The middleware check was moved to apps.py and changed to use the system checks framework. It was updated to check MIDDLEWARE in addition to MIDDLEWARE_CLASSES. It now checks that DebugToolbarMiddleware occurs in one of the settings. Updated installation documentation to reflect new requirements. The bundled example project was updated to current Django and Debug Toolbar configuration recommendations. Fixes django-commons#838
Is this project updated for 1.9?
The text was updated successfully, but these errors were encountered: