support params in sql panel that cannot be JSON encoded by default JSONEncoder #882
Labels
Comments
|
This issue is probably related: #747 |
jieter
added a commit
to zostera/django-debug-toolbar
that referenced
this issue
Dec 22, 2017
The param `strings_only=True` caused params with type `time`, `date` and `datetime` to not be converted to string by `NormalCursorWrapper._decode()`, and in turn causes the json dumping to fail. This change keeps `strings_only=True` for every type but datetime, date and time, enabling conversion to string in those cases. Fixes django-commons#882
jieter
added a commit
to zostera/django-debug-toolbar
that referenced
this issue
Dec 22, 2017
The param `strings_only=True` caused params with type `time`, `date` and `datetime` to not be converted to string by `NormalCursorWrapper._decode()`, and in turn causes the json dumping to fail. This change keeps `strings_only=True` for every type but datetime, date and time, enabling conversion to string in those cases. Fixes django-commons#882
jieter
added a commit
to zostera/django-debug-toolbar
that referenced
this issue
Dec 22, 2017
The param `strings_only=True` caused params with type `time`, `date` and `datetime` to not be converted to string by `NormalCursorWrapper._decode()`, and in turn causes the json dumping to fail. This change keeps `strings_only=True` for every type but datetime, date and time, enabling conversion to string in those cases. Fixes django-commons#882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If sql params are values that cannot be encoded by the built-in
json.JSONEncoder, then the sql panel doesn't get the params and subsequently can't perform the query orEXPLAINthe query.In my case, I often have params that are instance of
datetime.datetime.I currently use the following patch: zt-initech@47e7664
It is not very nice. I don't like using both JSON and pickle, and there are probably other problems.
How do you think this problem should be fixed?
For example, should params always be pickled?
Can you help me fix this patch to get it merged upstream?
The text was updated successfully, but these errors were encountered: