Skip to content

Template Panel Bugfix #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

noahsilas
Copy link

The template panel breaks the context stack in django 1.2; the attached commits are my attempt at fixing it while retaining compatibility for django 1.1.

details:
The Template.render method became the Template._render method. The new render method performs some of the context stack functions, and replacing this function with the instrumented_test_render method means that template rendering can get real wacky.

I haven't been able to test this in django 1.1 - I think that it works, but someone should probably double check for completeness.

@noahsilas
Copy link
Author

And, of course, too late I notice that you've fixed it in develop. Nevermind, and thanks!

@robhudson
Copy link
Contributor

I think I need to add a note somewhere about the develop branch. It's relatively new. Would it have helped if there was a note in the readme?

@noahsilas
Copy link
Author

Yeah, I checked out the readme, and if there had been a pointer to the develop branch I would have checked there first. Of course, now I know and will make sure that I'm working off of that branch if I'm troubleshooting again. :-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants