Skip to content

Fix example.urls to work with Django 2.0 #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Fix example.urls to work with Django 2.0 #1034

merged 1 commit into from
Jan 23, 2018

Conversation

jdufresne
Copy link
Contributor

Fixes unhandled exception:

django.core.exceptions.ImproperlyConfigured: Passing a 3-tuple to include() is not supported. Pass a 2-tuple containing the list of patterns and app_name, and provide the namespace argument to include() instead.

Fixes unhandled exception:

  django.core.exceptions.ImproperlyConfigured: Passing a 3-tuple to
  include() is not supported. Pass a 2-tuple containing the list of
  patterns and app_name, and provide the namespace argument to include()
  instead.
@codecov
Copy link

codecov bot commented Jan 21, 2018

Codecov Report

Merging #1034 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files          24       24           
  Lines        1294     1294           
  Branches      176      176           
=======================================
  Hits         1089     1089           
  Misses        156      156           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9964a20...41623ac. Read the comment docs.

@matthiask
Copy link
Member

Thanks!

@matthiask matthiask merged commit 28257ab into django-commons:master Jan 23, 2018
@jdufresne jdufresne deleted the fix-example branch January 25, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants