Skip to content

Validate duplicate middleware load #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2018
Merged

Validate duplicate middleware load #1052

merged 3 commits into from
Apr 13, 2018

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Apr 5, 2018

Protection for #986.

@kezabelle
Copy link
Contributor

Looks sensible enough to me.

@matthiask
Copy link
Member

To me as well, but the build fails with a flake8 error:
https://travis-ci.org/jazzband/django-debug-toolbar/jobs/362824956

Can you please fix this @ad-m and ping me after this?

@codecov
Copy link

codecov bot commented Apr 13, 2018

Codecov Report

Merging #1052 into master will decrease coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1052      +/-   ##
=========================================
- Coverage   84.33%   84.2%   -0.13%     
=========================================
  Files          24      24              
  Lines        1296    1298       +2     
  Branches      176     177       +1     
=========================================
  Hits         1093    1093              
- Misses        155     156       +1     
- Partials       48      49       +1
Impacted Files Coverage Δ
debug_toolbar/apps.py 89.74% <66.66%> (-4.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bdecf1...1d90573. Read the comment docs.

@ad-m
Copy link
Contributor Author

ad-m commented Apr 13, 2018

Fixed.

@matthiask
Copy link
Member

Thank you!

@matthiask matthiask merged commit c7e79ad into django-commons:master Apr 13, 2018
@blueyed
Copy link
Contributor

blueyed commented Sep 13, 2018

I think this should be a warning only.
See #1102.

@ad-m ad-m deleted the patch-1 branch September 13, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants