Reactor js part 2 #1083
Closed
Reactor js part 2 #1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not: not supported in edge https://caniuse.com/#feat=details
This is duplicated functionality. You can already toggle the entries using .djToggleSwitch
AFAIU it is never used because the background-color is always overwritten by applyStyle
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 24 24
Lines 1318 1318
Branches 178 178
=======================================
Hits 1111 1111
Misses 157 157
Partials 50 50
Continue to review full report at Codecov.
|
this is already handled in the close.djDebug event listener
already done in close.djDebug handler
|
Replaced by #1085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues my work from #1077.
I think I found some code that was not really used. I am not completely sure though.
Note that the
<details>element I used to replace some functionality is currently not supported by edge.I plan to continue working on this code with the aim to remove jquery. This is a lot of work though and I am not sure how long it will take. So I prefer to do small steps and get your feedback often. If you would like me to prepare a single large pull request I could probably also do that, but it would take some time.