Use defer attribute on all script tags, remove inline JS #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm deploying the experimental `Feature-Policy` on my site. I tried disabling the `sync-script` policy, which blocks HTML-parse-blocking JavaScript, and django-debug-toolbar broke because its script tags aren't async or deferred. There's a bit more information about this feature, and a demo at https://feature-policy-demos.appspot.com/sync-script.html?on I've added `defer` to all the `<script>` tags, which makes them execute after HTML parsing has finished, in order. There was also one inline script for redirects which I've extracted - this would break for `sync-script` but also for use of `Content-Security-Policy` blocking inline JavaScript, which has been supported since django-commons#704 but it seems this was missed. Tested by using the `example` app, redirect interception worked and every panel loaded and looked right.
Contributor
Author
|
@graingert you added CSP and like security features, perhaps you'd like to check this? |
graingert
suggested changes
Oct 25, 2018
| @@ -0,0 +1,3 @@ | |||
| document.addEventListener('DOMContentLoaded', function () { | |||
Contributor
There was a problem hiding this comment.
This should be redundant with defer
Contributor
Author
There was a problem hiding this comment.
Idk how far back django-debug-toolbar tries to support, but ancient browsers don't support defer, so best to leave it here?
Contributor
There was a problem hiding this comment.
https://caniuse.com/#feat=script-defer goes back to IE6
Also the script tag is below the element so even if it fell back to sync it would work
graingert
suggested changes
Oct 25, 2018
| @@ -0,0 +1,3 @@ | |||
| document.addEventListener('DOMContentLoaded', function () { | |||
| document.getElementById('redirect_to').focus(); | |||
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
This is focussing a link not a form element :(
Member
|
Thanks! |
Contributor
Author
|
No worries, thanks for active maintenance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm deploying the experimental
Feature-Policyon my site. I tried disabling thesync-scriptpolicy, which blocks HTML-parse-blocking JavaScript, and django-debug-toolbar broke because its script tags aren't async or deferred.There's a bit more information about this feature, and a demo at https://feature-policy-demos.appspot.com/sync-script.html?on
I've added
deferto all the<script>tags, which makes them execute after HTML parsing has finished, in order. There was also one inline script for redirects which I've extracted - this would break forsync-scriptbut also for use ofContent-Security-Policyblocking inline JavaScript, which has been supported since #704 but it seems this was missed.Tested by using the
exampleapp, redirect interception worked and every panel loaded and looked right.