Handle removed staticfiles.templatetags in Django 3.0 #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I suspect that changing |
Since Django version 1.10, commit: django/django@cf546e1 The module django.contrib.staticfiles.templatetags.staticfiles does not have the attribute staticfiles_storage. So it doesn't require any attention in StaticFilesPanel. Further, the module django.contrib.staticfiles.templatetags.staticfiles was deprecated in Django 2.1: https://docs.djangoproject.com/en/dev/releases/2.1/#id2 > {% load staticfiles %} and {% load admin_static %} are deprecated in > favor of {% load static %}, which works the same. And will be removed in Django 3.0: https://docs.djangoproject.com/en/dev/releases/3.0/#features-removed-in-3-0 > The staticfiles and admin_static template tag libraries are removed. Importing it causes an ImportError on Django 3.0. Removing the import fixes tests against the Django master branch.
|
Thanks, excellent point! That makes the cleanup even easier. In the latest revision I have completely removed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django.contrib.staticfiles.templatetags.staticfiles was deprecated in Django 2.1:
https://docs.djangoproject.com/en/dev/releases/2.1/#id2
And will be removed in Django 3.0:
https://docs.djangoproject.com/en/dev/releases/3.0/#features-removed-in-3-0
Catch and ignore an
ImportErroras the module may not exist. Fixes tests against the Django master branch.