Restructure the Panel class to execute more like the MIDDLEWARE #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Feb 24, 2019
|
This is an excellent idea. I should probably polish the state of current things and publish a release first. |
|
@matthiask that would be a better approach. |
This allows the ProfilingPanel to no longer skip remaining panels or middlewares. This change is backwards incompatible. Third party panels will need to adjust to use this new architecture. It removes support for Django 1.11's deprecated MIDDLEWARE_CLASSES setting. The Panel.__init__() method is now passed a get_response argument. The Panel.process_request() method must now always return a response. Usually this is the response returned by get_response() but may also return a different response as is the case in the ``RedirectsPanel``. Panel.process_response() and Panel.process_view() have been removed. Fixes #1135
That sounds good to me. Ping me if you need me to rebase or modify anything after that goes through. |
|
@matthiask @auvipy If we're going to introduce backwards incompatibility, maybe we get some other cases out of the way at the same time. WDYT? Some that come to mind:
If this is agreeable, I can submit separate PRs for those points. |
|
IMHO, it's time to drop python 2 from next major release which breaks BC. |
auvipy
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
ProfilingPanelto no longer skip remaining panels or middlewares.This change is backwards incompatible. Third party panels will need to adjust to use this new architecture. It removes support for Django 1.11's deprecated
MIDDLEWARE_CLASSESsetting.The
Panel.__init__()method is now passed a get_response argument. ThePanel.process_request()method must now always return a response. Usually this is the response returned byget_response()but may also return a different response as is the case in theRedirectsPanel.Panel.process_response()andPanel.process_view()have been removed.Fixes #1135