Handle SQL commands executed using as psycopg2 Composed object #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Composed object is the recommended way of composing SQL statements.
The SQL panel is currently expecting an string sql. Executing a composed
sql command will cause the following exception:
```
======================================================================
ERROR: test_execute_with_psycopg2_composed_sql (tests.panels.test_sql.SQLPanelTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/haki/src/django-debug-toolbar/tests/panels/test_sql.py", line 228, in test_execute_with_psycopg2_composed_sql
cursor.execute(command)
File "/home/haki/src/django-debug-toolbar/debug_toolbar/panels/sql/tracking.py", line 184, in execute
return self._record(self.cursor.execute, sql, params)
File "/home/haki/src/django-debug-toolbar/debug_toolbar/panels/sql/tracking.py", line 156, in _record
"is_select": sql.lower().strip().startswith("select"),
AttributeError: 'Composed' object has no attribute 'lower'
```
The solution is to cast the sql to string. If it's already string - no harm. If it's a
`Composable` object, it will return the composed SQL as str.
d868f59 to
98ebfbe
Compare
|
CI fail seem unrelated. Looks like some trouble connecting to mariadb for testing... |
|
Might be a duplicate of #1040 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Composed object is the recommended way of composing SQL statements.
The SQL panel is currently expecting an string sql. Executing a composed
sql command will cause the following exception:
The solution is to cast the sql to string. If it's already string - no harm. If it's a
Composableobject, it will return the composed SQL as str.