Introduce Prettier to format JavaScript and CSS files - #1338
Conversation
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
Thanks for adding this!
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
I didn't notice that Travis broke on the style test. Sorry for the extra email.
|
I'm a bit confused why this fails on Travis. I do not get the same error when running locally. Any ideas? |
|
Hmm, the additional logging was eaten somewhere. I can't reproduce this locally with node 12.16.2 that Travis claims to use. |
|
Ah ok. This is failing because Travis runs an old version of node.js, but prettier requires 10+. I'll see what our options are here. |
|
I have updated the Travis |
|
Good find!
…On Fri, Sep 25, 2020, 7:33 PM Jon Dufresne ***@***.***> wrote:
I have updated the Travis dist to bionic, green again 🙂 .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1338 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJYZP4DTOMY5IQJZXK3543SHUZFNANCNFSM4RY65J3A>
.
|
|
Thanks, this is awesome! I didn't merge this yet because of all the pull requests in flight. Let's merge this when things have calmed down a bit :-) |
Prettier is an opinionated formatting tool for JavaScript and CSS. Similar to how Black is for Python, Prettier automates all formatting decisions for JS and CSS files, thus eliminating differences in preferences. Contributors can use "make style" just like before to restyle files.
|
I've cherry-picked this change and re-run |
3 participants
Prettier is an opinionated formatting tool for JavaScript and CSS.
Similar to how Black is for Python, Prettier automates all formatting
decisions for JS and CSS files, thus eliminating differences in
preferences. Contributors can use "make style" just like before to
restyle files.