Unify show/hide JS logic through the djdt-hidden class - #1340
Merged
Conversation
Using a class -- rather than manipulating inline CSS -- is more robust as it doesn't assume the hidden object is styled as 'display: block;'. The djdt-hidden class already existed, so use it for all hide/show code.
Member
|
I'll admit, I'm a bit cautious after the last HTML/JS change we made that broke something else. What tests did you all run as a part of verifying this code change? |
Contributor
Author
|
I tested this by running the Selenium tests (all pass) and by doing manual testing in the example app. I tried to hit all areas I know show/hide HTML. If you happen to find a bug, let me know and I'll happily add Selenium test to cover it. |
Member
|
Nope, that's good enough for me. Thank you for providing that information! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a class -- rather than manipulating inline CSS -- is more robust
as it doesn't assume the hidden object is styled as 'display: block;'.
The djdt-hidden class already existed, so use it for all hide/show code.