Simplify fetch() calls in JavaScript - #1348
Merged
Merged
Conversation
The fetch() init object does not have a property "url", so remove it. The element being either a button or a element is mutually exclusive, so use an "else if". When a button is pressed, an enclosing form element already exist, so remove the guard. Assign the object properties in the object literal instead of after.
Member
|
I think this looks good, thanks! |
tim-schilling
approved these changes
Oct 1, 2020
tim-schilling
left a comment
Member
There was a problem hiding this comment.
Looks good! I verified things are working locally.
Member
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fetch() init object does not have a property "url", so remove it.
The element being either a button or a element is mutually exclusive, so
use an "else if".
When a button is pressed, an enclosing form element already exist, so
remove the guard.
Assign the object properties in the object literal instead of after.