Skip to content

Fix #1184 -- Replace loading gif with css animation #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

codingjoe
Copy link
Contributor

@codingjoe codingjoe commented Sep 29, 2020

You can test it by loading a page, then disabling the network in the browsers debug console followed by opening any toolbar tab.

The whole thing looks like this:
Screenshot 2020-09-29 at 14 46 06

@codingjoe codingjoe requested a review from jdufresne September 29, 2020 12:51
Copy link
Contributor

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is really neat. Thanks for contributing it.

@codingjoe
Copy link
Contributor Author

@jdufresne I removed the display property as suggested. I guess you are most familiar with the merge and release proceedings. I'd leave that to you, if that's ok.

@matthiask matthiask merged commit 76049e6 into django-commons:master Sep 30, 2020
@matthiask
Copy link
Member

Thank you, that's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants