Skip to content

Add Python3.9 support. #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Add Python3.9 support. #1411

merged 2 commits into from
Dec 2, 2020

Conversation

@hramezani
Copy link
Contributor

@hramezani hramezani commented Nov 29, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 29, 2020 •
edited
Loading

Codecov Report

Merging #1411 (2fadc37) into master (621019c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
+ Coverage   87.54%   87.57%   +0.02%     
==========================================
  Files          29       29              
  Lines        1574     1577       +3     
  Branches      221      220       -1     
==========================================
+ Hits         1378     1381       +3     
  Misses        145      145              
  Partials       51       51
Impacted Files Coverage Δ
debug_toolbar/panels/request.py 100.00% <0.00%> (ø)
debug_toolbar/panels/history/panel.py 95.83% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621019c...2fadc37. Read the comment docs.

matthiask
matthiask requested changes Dec 1, 2020
View reviewed changes
Copy link
Member

@matthiask matthiask left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (apart from the comment abovebelow)

tox.ini Outdated
py{36,37,38}-dj{30,31}-sqlite
py{36,37,38}-djmaster-sqlite
py{37,38}-dj{22,30,31}-{postgresql,mysql}
py{36,37,38,39}-dj{22,30,31,master}-{sqlite,postgresql,mysql}
Copy link
Member

@matthiask matthiask Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to ask you to revert this change. Upcoming Django versions may drop support for Python versions and while the previous format is a bit more verbose it's a bit more obvious to me how to manage/remove individual combinations.

Copy link
Contributor Author

@hramezani hramezani Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this change and add 39 to the end of each list

@folt folt mentioned this pull request Dec 1, 2020
Open
@hramezani
Copy link
Contributor Author

hramezani commented Dec 1, 2020

Looks good to me (apart from the comment abovebelow)

I address your comment and also add Python and Django supported version badges to README.rst in a separate commit.

@matthiask
Copy link
Member

matthiask commented Dec 2, 2020

Thanks!

@matthiask matthiask merged commit f277b9d into django-commons:master Dec 2, 2020
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthiask matthiask matthiask requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hramezani @matthiask