AttributeError in RequestVarsPanel when using FallbackMiddleware #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as a request attribute. This is especially true for 'fallback' type of views that are rendered from within middleware, such as the one used in Django's own flatpages.
|
I was having the same issue and this fixed it for me as well. |
|
This also fixes the problem I had with adding DjDT middleware before the flatpages middleware. (The same problem as reported here: http://groups.google.com/group/django-debug-toolbar/msg/78d0d0026be80757) Thanks for the work dokterbob! |
|
Please pull this. It is a verified fix for a very annoying problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Rob,
Just now I ran into a bug in a situation where
process_viewwas not called on the debug panels, as the response was actually returned by a middleware which caught an exception. The code I ran into this with is very similar to Django's own FallbackMiddleware in the static contrib module. The result was anAttributeErrorinrequest_vars.pyas you're assuming some ofview_func's attributes to be present.So I made a simple patch checking for the existence of
view_funcin this particular panel and updating the context consequently.Kinds regards,
Mathijs
PS. The error was spotted in a setup running Django 1.3 from SVN.